Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Add defaultValues to respective select menu components data #10265

Merged
merged 4 commits into from
May 13, 2024
Merged

types: Add defaultValues to respective select menu components data #10265

merged 4 commits into from
May 13, 2024

Conversation

fronkdev
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Added 'defaultValues' typings on ChannelSelectMenuComponentData, RoleSelectMenuComponentData, and UserSelectMenuComponentData.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@fronkdev
Update index.d.ts
baf0347 
Added 'defaultValues' typings for ChannelSelectMenuComponentData, RoleSelectMenuComponentData, and UserSelectMenuComponentData.
@fronkdev fronkdev requested a review from a team as a code owner May 10, 2024 14:04
@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 1:24pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 1:24pm

@Jiralite Jiralite changed the title Update index.d.ts types: Add defaultValues to respective select menu components data May 10, 2024
Jiralite
Jiralite previously requested changes May 10, 2024
View reviewed changes
packages/discord.js/typings/index.d.ts Show resolved Hide resolved
@fronkdev
Update index.d.ts
74cbfbc 
Adding 'defaultValues' typing to MentionableSelectMenuComponentData
@Jiralite Jiralite added this to the discord.js 14.15.3 milestone May 10, 2024
@Jiralite Jiralite dismissed their stale review May 13, 2024 13:22

Resolved.

@kodiakhq kodiakhq bot merged commit c2432d5 into discordjs:main May 13, 2024
5 checks passed
@Azzraya Azzraya mentioned this pull request Jun 23, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jun 24, 2024
Open
@yaasiin-ayeva yaasiin-ayeva mentioned this pull request Jun 24, 2024
Merged
This was referenced Jun 24, 2024
Merged
Merged
@ciscoderp ciscoderp mentioned this pull request Jun 24, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 24, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@mezotv mezotv mentioned this pull request Aug 19, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjGam benjGam benjGam approved these changes

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js 14.15.3
Development

Successfully merging this pull request may close these issues.
5 participants
@fronkdev @vladfrangu @kyranet @Jiralite @benjGam