refactor(actions): safer getChannel calls #10434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
kyranet
approved these changes
Aug 9, 2024
Qjuh
suggested changes
Aug 15, 2024
Qjuh
approved these changes
Aug 15, 2024
vladfrangu
approved these changes
Aug 15, 2024
SpaceEEC
approved these changes
Aug 19, 2024
imnaiyar
pushed a commit
to imnaiyar/discord.js
that referenced
this pull request
Aug 20, 2024
* refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot
added a commit
that referenced
this pull request
Aug 20, 2024
* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <[email protected]> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> * feat(Attachment): add `title` (#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Danial Raza <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <[email protected]> Co-authored-by: Jeroen Claassens <[email protected]> Co-authored-by: DD <[email protected]>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
* refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
nyapat
pushed a commit
to nyapat/discord.js
that referenced
this pull request
Sep 9, 2024
* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (discordjs#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <[email protected]> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> * feat(Attachment): add `title` (discordjs#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (discordjs#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (discordjs#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Almeida <[email protected]> Co-authored-by: Danial Raza <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <[email protected]> Co-authored-by: Jeroen Claassens <[email protected]> Co-authored-by: DD <[email protected]>
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #10393 and also does a little spring cleaning on areas that could have also been dangerous in the same way.
The gist of #10393 was that it was especially happening when a message sent unarchived a thread, and yet it only sometimes caused the error. It seems that sometimes, Discord was sending the
MESSAGE_CREATEpayload before theTHREAD_UPDATE. The latter normally comes first and populates our cache, which yields to the subsequentgetChannelcaused by theMESSAGE_CREATEto return from cache.In cases when the opposite was happening, before #10278 we were unable to resolve the channel type and would simply skip it, not adding it to cache at all (and also skipping the messageCreate) as a result. This is a fundamental flaw of how those partials work, and should be addressed with either the next major, or the library's rewrite. There is no easy way to otherwise fix this right now.
After #10278, we were essentially passing full message objects from
MESSAGE_CREATEtogetChannel, messages, which, have atypeproperty, often0, which lead to a successful channel creation with jank data.With this fix, we're back to the old behavior of dropping those events. Regarding the properties I chose to forward, I followed the payload docs found here https://discord.com/developers/docs/topics/gateway-events#gateway-events