Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recurring scheduled events #10447

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 15, 2024

Please describe the changes this PR makes and why it should be merged:

Upstream:

Depends on:

Status and versioning classification:

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 6:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 6:35pm

@almeidx almeidx force-pushed the feat/recurring-scheduled-events branch from 86a2a6a to 4fd0f9d Compare August 15, 2024 18:49
@almeidx almeidx force-pushed the feat/recurring-scheduled-events branch from 4fd0f9d to cd1533f Compare August 20, 2024 17:37
@almeidx almeidx marked this pull request as ready for review August 20, 2024 17:54
@almeidx almeidx requested a review from a team as a code owner August 20, 2024 17:54
@almeidx almeidx added this to the discord.js 14.16 milestone Aug 20, 2024
@almeidx almeidx force-pushed the feat/recurring-scheduled-events branch from 98c0970 to 42b9345 Compare September 1, 2024 20:57
@almeidx almeidx linked an issue Sep 2, 2024 that may be closed by this pull request
@reteps
Copy link

reteps commented Sep 13, 2024

Why is the status 'blocked'?

@didinele
Copy link
Member

didinele commented Sep 13, 2024

Usually that means the semver status of your PR is higher than what we currently want to release, the blocked label ensure the PR doesn't get merged.

For instance, we might currently want a patch (bug fixes only) for our next release, but your PR is minor (features + bug fixes), so we're holding it off.

Specifically though, I'm not quite sure what we have planned right now given 14.16.2 was just released yesterday.

@kodiakhq kodiakhq bot merged commit 9aa3b63 into main Sep 29, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the feat/recurring-scheduled-events branch September 29, 2024 18:41
Jiralite pushed a commit that referenced this pull request Sep 30, 2024
* feat: recurring scheduled events

* fix: nullable on patch

* docs: remove unnecessary parenthesis

Co-authored-by: Vlad Frangu <[email protected]>

---------

Co-authored-by: Vlad Frangu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for APIGuildScheduledEventRecurrenceRule
6 participants