-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make changes to PresenceData typings and docs #5317
Conversation
Just for context purpose: I got confused and thought |
Co-authored-by: Sugden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This needs its conflicts resolved. |
Please describe the changes this PR makes and why it should be merged:
Fixes: #5316
Also, for some reason, jsdoc description of
ActivityOptions
was missing thename
property.Status and versioning classification: