Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make changes to PresenceData typings and docs #5317

Merged
merged 6 commits into from
Apr 14, 2021
Merged

feat: make changes to PresenceData typings and docs #5317

merged 6 commits into from
Apr 14, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Feb 12, 2021

Please describe the changes this PR makes and why it should be merged:

Fixes: #5316
Also, for some reason, jsdoc description of ActivityOptions was missing the name property.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iShibi
Copy link
Contributor Author

iShibi commented Feb 12, 2021

Just for context purpose: I got confused and thought shardID goes inside activities in PresenceData just like it does in ActivityOptions. Fixed my mistake in 7179689 😓

NotSugden
NotSugden suggested changes Feb 13, 2021
View reviewed changes
src/structures/ClientUser.js Outdated Show resolved Hide resolved
NotSugden
NotSugden reviewed Feb 14, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@pettinen pettinen mentioned this pull request Mar 1, 2021
Closed
@vaporoxx vaporoxx mentioned this pull request Mar 15, 2021
Closed
@vaporoxx vaporoxx mentioned this pull request Apr 8, 2021
Closed
MattIPv4
MattIPv4 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

wolf-yuan-6115
wolf-yuan-6115 approved these changes Apr 11, 2021
View reviewed changes
Copy link

@wolf-yuan-6115 wolf-yuan-6115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kyranet
Copy link
Member

kyranet commented Apr 11, 2021

This needs its conflicts resolved.

@iCrawl iCrawl merged commit eb43ce4 into discordjs:master Apr 14, 2021
@iShibi iShibi deleted the fix-5316 branch May 14, 2021 09:33
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotSugden NotSugden NotSugden requested changes

@MattIPv4 MattIPv4 MattIPv4 approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Nimplex Nimplex Nimplex approved these changes

@wolf-yuan-6115 wolf-yuan-6115 wolf-yuan-6115 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.

Setting client presence invalidates session
10 participants
@iShibi @kyranet @MattIPv4 @vladfrangu @iCrawl @SpaceEEC @NotSugden @Nimplex @wolf-yuan-6115 @almostSouji