Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(PermissionOverwriteOptions): remove unused interface #5651

Merged
merged 1 commit into from
May 27, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented May 19, 2021

Please describe the changes this PR makes and why it should be merged:

This PR removes the unused PermissionOverwriteOptions interface from index.d.ts. There is another interface named PermissionOverwriteOption whose jsdoc typedef is PermissionOverwriteOptions. So, I renamed this interface to PermissionOverwriteOptions so that it matches with the typedef.

This PR is a result of the convo I had with CheeseBoye in the support server.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like our declarations😁

@iCrawl iCrawl merged commit b40027b into discordjs:master May 27, 2021
@iShibi iShibi deleted the perm-overwrite-options branch May 30, 2021 10:26
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants