Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Integration): Cleanup removed methods #6220

Merged
merged 6 commits into from
Jul 29, 2021
Merged

chore(Integration): Cleanup removed methods #6220

merged 6 commits into from
Jul 29, 2021

Conversation

GoldenAngel2
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
The method no longer exists (and/or bots don't have access to it)

DiscordAPIError: 405: Method Not Allowed

Status and versioning classification:
Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@SpaceEEC
Copy link
Member

The same applies to Integration#edit and Guild#createIntegration, doesn't it?
Neither are documented anymore. (Only get and delete seem to be https://discord.com/developers/docs/resources/guild#get-guild-integrations)

@GoldenAngel2
Copy link
Contributor Author

GoldenAngel2 commented Jul 29, 2021 •
edited
Loading

Since it's not documented anymore, it's safe to say those should be removed aswell.

After testing, if you send a request to the PATCH endpoint it gives you (DiscordAPIError: Bots cannot use this endpoint) so yeah that can be removed.

@GoldenAngel2 GoldenAngel2 changed the title chore(Integration): Remove sync chore(Integration): Cleanup removed methods Jul 29, 2021
@GoldenAngel2
Copy link
Contributor Author

Guild#createIntegration, Integration#edit and Integration#sync is now removed.

SpaceEEC
SpaceEEC requested changes Jul 29, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
SpaceEEC
SpaceEEC approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iCrawl iCrawl added this to the Version 13 milestone Jul 29, 2021
@iCrawl iCrawl merged commit 4beb647 into discordjs:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
3 participants
@GoldenAngel2 @SpaceEEC @iCrawl