Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: grammar fixes #6345

Merged
merged 3 commits into from
Aug 8, 2021
Merged

docs: grammar fixes #6345

merged 3 commits into from
Aug 8, 2021

Conversation

Muh9049
Copy link
Contributor

@Muh9049 Muh9049 commented Aug 8, 2021

Please describe the changes this PR makes and why it should be merged:

This PR fixes grammar regarding plural possessives.

In some places, it said something like The value set for a team members's membership state:. Not only is this incorrect (since it would be The value set for a team members' membership state:), but it does make it too consistent with documentation in other places.

For example, for stickers, nowhere does it say The value set for a stickers's type:; instead it says The value set for a sticker's type: which uses genitive case, so the same thing should apply with others.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@DaStormer
Copy link
Contributor

Prefix should be docs; fix appears in the change-log under bug fixes

@Muh9049
Copy link
Contributor Author

Muh9049 commented Aug 8, 2021

Prefix should be docs; fix appears in the change-log under bug fixes

Oh right, I did docs: in the other PRs oops lol

@Muh9049 Muh9049 changed the title fix: grammar docs: grammar fixes Aug 8, 2021
@kyranet kyranet requested a review from iCrawl August 8, 2021 07:33
@kyranet kyranet added this to the Version 13.1 milestone Aug 8, 2021
@iCrawl iCrawl merged commit f13d27c into discordjs:main Aug 8, 2021
@Muh9049 Muh9049 deleted the grammar-fixes branch August 8, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants