Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(ApplicationCommandData): Stronger typings for ApplicationCommandData variants. #6382

Merged

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Aug 11, 2021

Please describe the changes this PR makes and why it should be merged:

This introduces compile-time constraints for the changes recently added to ApplicationCommandData:

  • description is required when type is set to 'CHAT_INPUT'
  • options is only available to commands of 'CHAT_INPUT' types as per the discord docs

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit 75b48d8 into discordjs:main Aug 11, 2021
@suneettipirneni suneettipirneni deleted the typings/applicationCommandData branch August 11, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants