types(ApplicationCommandManager): Deprecate old *Data type usages and allow camel cased dapi types to be used

[suneettipirneni]

Please describe the changes this PR makes and why it should be merged:

Ref: #6958

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[ImRodry]

Do we really need to add a dependency for types only? Most people don't use typescript and the package offers much more than the type that is being imported, I believe we could simply create the type ourselves instead

[suneettipirneni]

Do we really need to add a dependency for types only? Most people don't use typescript and the package offers much more than the type that is being imported, I believe we could simply create the type ourselves instead

It's a dev dep, so why does it matter. And the camel case util type here is more sophisticated. It's not that simple to implement one our own that's as robust as this one.

[ImRodry]

If it’s a dev dev then these types won’t even work at all because the package wouldn’t get installed. We can simply copy the type from them and add it ourselves

[almeidx]

type Camelize<S extends string> = S extends `${infer FirstPart}_${infer Rest}`
    ? `${FirstPart}${Capitalize<Camelize<Rest>>}`
    : S;

type CamelizeDeep<T> = T extends Array<infer Inner>
    ? Array<CamelizeDeep<Inner>>
    : T extends object
        ? { [Key in keyof T as Camelize<Key & string>]: CamelizeDeep<T[Key]> }
        : T;

playground

[ImRodry]

Should probably revert the package-lock changes?

[suneettipirneni]

We won't be using our own version of Camelizer. We are going to stick with the package that was originally brought up in this PR.

[vladfrangu]

Well what do ya know! This needs a rebase

[vladfrangu]

🎉

[iCrawl]

This needs another rebase for the new type testing PR that landed.