Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Fix channel create overloads #7294

Merged
merged 2 commits into from
Jan 19, 2022
Merged

types: Fix channel create overloads #7294

merged 2 commits into from
Jan 19, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 18, 2022

Please describe the changes this PR makes and why it should be merged:
There were issues with creating channels in TypeScript:

  1. <GuildChannelManager>.create() always required two arguments
  2. Hovering over <GuildChannelManager>.create() would always yield a deprecation notice, despite being none
  3. <GuildChannelManager>.create("name", {}) would not be a TextChannel
  4. Only "GuildStore" and not the enumerable as well were being checked for in the deprecation notice

This pull request fixes those issues.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the discord.js v14 milestone Jan 19, 2022
@iCrawl iCrawl added the typings label Jan 19, 2022
@iCrawl
Copy link
Member

iCrawl commented Jan 19, 2022

Is this still needed with the enum changes merged?

@Jiralite
Copy link
Member Author

Yes @iCrawl, all points but the last still stand.

@iCrawl iCrawl merged commit 1c6c944 into discordjs:main Jan 19, 2022
@Jiralite Jiralite deleted the channel-overloads branch January 23, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants