Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add keepNames tsup option #7385

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Conversation

DTrombett
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Add the keepNames option to tsup configs to avoid errors or such to have a minified name like D.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@kyranet kyranet added the chore label Feb 1, 2022
@ImRodry
Copy link
Contributor

ImRodry commented Feb 1, 2022

Can we please just remove minify? Looking at source code to trace back an error is extremely painful with this option and the size reduction is very small (although relatively significant, it’s only 15kb in rest for example)

@vladfrangu
Copy link
Member

I don't see how seeing where in our code the issue started from helps you at all

@ImRodry
Copy link
Contributor

ImRodry commented Feb 1, 2022

I don't see how seeing where in our code the issue started from helps you at all

There can always be bugs in the package and even if there aren’t it’s good to know what methods are being called and how the code reached that point. That should not be taken away from us

@iCrawl iCrawl merged commit 34120bb into discordjs:main Feb 2, 2022
@DTrombett DTrombett deleted the fix/keepnames branch February 2, 2022 14:23
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants