-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): Add unsafe message component builders #7387
feat(components): Add unsafe message component builders #7387
Conversation
96bbed4
to
7a321f0
Compare
Can't this be an option on the original builders and not a new class? |
We discussed this internally, we would rather have a separate class than have an if branch for all methods on one class. |
Isn't it supposed to have the types for each parameter in |
They are coming from ts file which'll auto generate types. If you are saying about adding types in main package types then this pr isn't reexporting them in djs |
Got it, thanks for explaining. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types also
This needs a rebase. |
9cbf0ad
to
b6796e3
Compare
Please describe the changes this PR makes and why it should be merged:
This adds new builders that don't perform any validation on input:
UnsafeButtonComponent
UnsafeSelectMenuComponent
UnsafeSelectMenuOption
UnsafeEmbed
If you'd like to use a shorter name I'd recommend renaming the imports for your needs:
Status and versioning classification: