feat: allow deletion of ephemeral messages

[monbrey]

• Add Ephemeral Message Delete changelog discord/discord-api-docs#5570

Breaking because it no longer throws an error, but a bugfix because it shouldn't throw an error here anymore.

Status and versioning classification:

• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated
discord-js	⬜️ Ignored (Inspect)		Oct 27, 2022 at 11:15AM (UTC)
discord-js-guide	⬜️ Ignored (Inspect)		Oct 27, 2022 at 11:15AM (UTC)

[kyranet]

I'd argue that it's still semver:major as-is because you're removing a property from ErrorCodes, which is a public and documented interface.

[SpaceEEC]

It should probably be deprecated instead then. 😅

[monbrey]

I'd argue that it's still semver:major as-is because you're removing a property from ErrorCodes, which is a public and documented interface.

I agree in theory and I'm happy to add it back, but the error can't be thrown by anything anymore.

[kyranet]

That is correct, but functions that read that property (e.g. error handlers) will break with this PR, that's why I consider it a breaking change.

Deprecating it is fine, however.

[codecov]

Codecov Report

Merging #8774 (996d592) into main (68d5712) will decrease coverage by 6.25%.
The diff coverage is n/a.

❗ Current head 996d592 differs from pull request most recent head 272ce26. Consider uploading reports for the commit 272ce26 to get more accurate results

@@            Coverage Diff             @@
##             main    #8774      +/-   ##
==========================================
- Coverage   92.06%   85.81%   -6.26%     
==========================================
  Files          10       91      +81     
  Lines        2093     9254    +7161     
  Branches      240     1125     +885     
==========================================
+ Hits         1927     7941    +6014     
- Misses        163     1271    +1108     
- Partials        3       42      +39     

Flag	Coverage Δ
brokers	65.24% <ø> (?)
builders	100.00% <ø> (?)
collection	100.00% <ø> (?)
proxy	81.53% <ø> (?)
rest	92.06% <ø> (ø)
util	100.00% <ø> (?)
utilities	100.00% <ø> (?)
voice	63.70% <ø> (?)
ws	59.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/voice/src/util/abortAfter.ts	100.00% <0.00%> (ø)
packages/ws/src/utils/IdentifyThrottler.ts	100.00% <0.00%> (ø)
packages/util/src/functions/range.ts	100.00% <0.00%> (ø)
packages/voice/src/audio/AudioPlayerError.ts	0.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/channel.ts	100.00% <0.00%> (ø)
packages/builders/src/components/Components.ts	100.00% <0.00%> (ø)
packages/brokers/src/brokers/redis/PubSubRedis.ts	84.48% <0.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts	100.00% <0.00%> (ø)
packages/builders/src/util/validation.ts	100.00% <0.00%> (ø)
.../src/strategies/sharding/WorkerShardingStrategy.ts	95.87% <0.00%> (ø)
... and 71 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more