Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTOptions: (really) small description update for cdn #9615

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

volcanofr
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

I just add "``" to uniform cdn @DefaultValue with others one (like api). The link is not broken anymore, because it do not work anymore.

Status and versioning classification:

  • This PR only includes non-code changes

I just add "``" to uniform cdn @DefaultValue with others one (like api).
The link is not broken anymore, because it do not work anymore.
@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jun 9, 2023 8:54am
discord-js-guide ⬜️ Ignored (Inspect) Jun 9, 2023 8:54am

@Jiralite Jiralite modified the milestones: rest 1.8.0, rest 2.0.0 Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #9615 (cd90ef8) into main (1ab60f9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head cd90ef8 differs from pull request most recent head 83508a8. Consider uploading reports for the commit 83508a8 to get more accurate results

@@            Coverage Diff             @@
##             main    #9615      +/-   ##
==========================================
- Coverage   58.19%   58.17%   -0.03%     
==========================================
  Files         227      227              
  Lines       14904    14892      -12     
  Branches     1131     1131              
==========================================
- Hits         8673     8663      -10     
+ Misses       6191     6189       -2     
  Partials       40       40              
Flag Coverage Δ
proxy 76.31% <ø> (ø)
rest 93.18% <100.00%> (+0.04%) ⬆️
ws 53.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rest/src/lib/REST.ts 98.91% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit a531dc9 into discordjs:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants