fix(GuildManager#fetch): inject shard id

[Syjalo]

Please describe the changes this PR makes and why it should be merged:

🤖 Generated by Copilot at 9bc0d99

Summary

✨🔧💾

This PR adds required for the Guild injection of the shard id

To handle more guilds in the bot
We added some sharding support
We imported ShardClientUtil
To assign each guild a shardId too
And cached them for better report

Walkthrough

• Import ShardClientUtil module to calculate shard IDs for guilds (link)
• Assign data.shardId the value of the shard ID for the guild ID (link)

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)	Visit Preview		Nov 4, 2023 5:00pm
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		Nov 4, 2023 5:00pm

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	74
🟢 Accessibility	96
🟢 Best practices	100
🟠 SEO	67
🔴 PWA	33

Lighthouse ran on https://discord-js-git-fork-syjalo-fix-inject-shard-id-discordjs.vercel.app/

[didinele]

What problem is this actually solving?

[Syjalo]

What problem is this actually solving?

Getting the shard in the Guild class

[Jiralite]

I'm assuming this is to cater towards those without the GUILDS intent?

[Syjalo]

Discord doesn't include the shard id in the response, discord.js injects it. And there it's missing. So currently <Guild>.shard returning undefined for the fetched guild.

discord.js/packages/discord.js/src/structures/Guild.js

Lines 134 to 136 in a9e1f60

	get shard() {
	return this.client.ws.shards.get(this.shardId);
	}

[didinele]

Discord doesn't include the shard id in the response, discord.js injects it. And there it's missing. So currently .shard returning undefined for the fetched guild.

This is what I was asking, you tagged this as fix but it was completely unclear if there was an error or bug you were actually addressing; LGTM.

[kyranet]

I'm neutral about this change, because Guild#shard[Id], while not documented as such, always meant what shard the guild came from, rather than being something we calculate.

If calculating the id of the shard is as reliable as the id of the shard the GUILD_CREATE payload came from, then we can probably look into making shardId a getter.

LGTM nevertheless, just wanted to note this.

---

That being said, if multi-process sharding is used, wouldn't that make the Guild#shard getter return undefined for guilds which shard is on another process?

[vladfrangu]

If calculating the id of the shard is as reliable as the id of the shard the GUILD_CREATE payload came from, then we can probably look into making shardId a getter

It'll probably be reliable for enough use cases to not cause issues.