Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): misc improvements #9940

Merged
merged 14 commits into from
Nov 13, 2023
Merged

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Nov 12, 2023

Please describe the changes this PR makes and why it should be merged:

  • Fixed api-extractor config, as it was invalid and made api-extractor always run with es3 as target
  • link tags to js builtins now also link to their documentation, formerly only worked in types
  • remove unneccessary | inname: | Type tokens
  • fix tsdoc in mainlib index.d.ts

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 8:53am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 8:53am

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these deprecation messages show up, they should be properly capitalised.

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #9940 (efdef4d) into main (dbb92e5) will decrease coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #9940      +/-   ##
==========================================
- Coverage   59.35%   59.29%   -0.06%     
==========================================
  Files         237      237              
  Lines       16840    16857      +17     
  Branches     1237     1237              
==========================================
  Hits         9995     9995              
- Misses       6800     6817      +17     
  Partials       45       45              
Flag Coverage Δ
brokers 63.49% <ø> (ø)
builders 95.53% <ø> (ø)
collection 99.32% <ø> (ø)
formatters 99.47% <ø> (ø)
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.82% <ø> (ø)
util 70.70% <ø> (ø)
voice 63.64% <ø> (ø)
website 0.00% <0.00%> (ø)
ws 52.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bsite/src/components/documentation/tsdoc/TSDoc.tsx 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants