Return full response body when fetching categories #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am definitely not a fan of a breaking change here. I'd recommend we create new methods that return the extra attributes. |
|
What are your thoughts on appending |
|
I think |
mikepack
force-pushed
the
mp-category-meta
branch
from
ecf3760
to
0c01209
Compare
|
This should be ready for review. The same can likely be done in |
Carmer
pushed a commit
to vangst/discourse_api
that referenced
this pull request
Apr 9, 2021
Carmer
pushed a commit
to vangst/discourse_api
that referenced
this pull request
Apr 9, 2021
Carmer
pushed a commit
to vangst/discourse_api
that referenced
this pull request
Apr 9, 2021
Carmer
pushed a commit
to vangst/discourse_api
that referenced
this pull request
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a fully flushed out PR but enough to get a conversation going around the neglected metadata when fetching categories.
Essentially, I'm trying to access metadata on category response, not just the categories/topics within. Specifically,
can_create_topicand other permissions, eg:discourse_api/spec/fixtures/category_latest_topics.json
Line 10 in 74c423c
This would be breaking, of course, but I'm not sure how to accomplish it otherwise. Once we align on direction, I can flush out the remainder and specs.