Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid explicitly naming the meta file #1520

Draft
wants to merge 1 commit into
base: series/0.18
Choose a base branch
from

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented May 13, 2024

Just an experiment for now. Related to #1517

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@kubukoz
Copy link
Member Author

kubukoz commented May 13, 2024

ok, I see. We're not doing this for a valid reason: we'd have to publish the protocol module every time we wanted to load a model. That might slow down the build, and just make for worse UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant