Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Fix for translation getter "ValueError: language_code can't be null" #164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for translation getter "ValueError: language_code can't be null" #164

wants to merge 5 commits into from

Conversation

carderm
Copy link

@carderm carderm commented Feb 11, 2019

No description provided.

@bplociennik
Copy link
Contributor

Thanks, @carderm for your code. Could you please fix travis tests or run rebase? Tests on master branch are working.

@carderm
Copy link
Author

carderm commented Feb 13, 2019

All done, hope that works ok! :)

Fix for yet another change-for-change's-sake from Divio.
deee2b4 
Changed index_title to lower case so that yet another breaking-change hurdle can be jumped over...
@carderm
Copy link
Author

carderm commented Mar 15, 2019

Thanks, @carderm for your code. Could you please fix travis tests or run rebase? Tests on master branch are working.

hi - let me know if any further changes are required? thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bplociennik bplociennik bplociennik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carderm @bplociennik @gdreich