Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose yaml to releases #1098

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

tgeoghegan
Copy link
Contributor

@tgeoghegan tgeoghegan commented Jun 13, 2024

This is working: https://github.com/divviup/divviup-api/actions/runs/9506015920/job/26202243402. The overall job failed because it can't overwrite the existing binaries, but uploading compose.yaml succeeded.

https://github.com/divviup/divviup-api/releases/tag/0.3.12

@tgeoghegan tgeoghegan requested a review from a team as a code owner June 13, 2024 20:05
@tgeoghegan tgeoghegan mentioned this pull request Jun 13, 2024
9 tasks
Copy link
Contributor

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but the compose.yaml file still has one dependency on the surrounding repo, so it won't work standalone just yet. The divviup_api_vite service has a build stanza, and mounts the webapp source code. We'll need to either use the existing divviup_api image's bundled assets, or bake a new image with just a static web server, the webapp assets, and a way to mount an appropriate api_url file in as well. (the former may be trickier to set up since it uses host-based routing, but maybe we can make it work with setting the right environment variables to localhost with specific ports)

@divergentdave
Copy link
Contributor

One other consideration: how will we phase updating the image version numbers in the compose file, tagging commits, and uploading release artifacts? For now, the compose file attached to a release will trail behind the version of the release itself. If we updated tags in the compose file before creating the release, then the compose file itself would have to go untested to some degree, since container images are generated after the release is created.

@inahga
Copy link
Contributor

inahga commented Jun 13, 2024

It was mentioned in comment in our design doc that we wanted the demo to be mainly CLI driven, so I think it's fair game to drop the divviup_api_vite service entirely from the user-facing compose.yaml.

@tgeoghegan
Copy link
Contributor Author

These are good points, and I noted them in #1096. But I think this PR, whose goal is to publish a YAML file, can go ahead.

@tgeoghegan tgeoghegan merged commit 8185776 into main Jun 13, 2024
10 of 16 checks passed
@tgeoghegan tgeoghegan deleted the timg/ship-compose-yaml branch June 13, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants