Only use Vite in compose.dev.yaml #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
approved these changes
Jun 17, 2024
.github/workflows/docker.yml
Outdated
| # Disable cone mode so we only grab a specific file | ||
| # https://github.com/actions/checkout?tab=readme-ov-file#fetch-only-a-single-file | ||
| # https://git-scm.com/docs/git-sparse-checkout | ||
| sparse-checkout-cone-mode: true |
There was a problem hiding this comment.
This doesn't match the linked example
Suggested change
| sparse-checkout-cone-mode: true | |
| sparse-checkout-cone-mode: false |
We want demo users to be able to get started with nothing but a `divviup` binary, a working Docker Compose install and `compose.yaml`. `divviup_api_vite` relies on having a local checkout of the static assets to serve. We now use the `diviup_api_integration_test` image to serve static assets from service `static_assets`. The assets in question are already present in the image being run in service `divviup_api`, but I did it this way for the following reasons: - `divviup-api` routes requests to the static asset handler based on hostname, making it difficult to serve alongside the API. I tried creating some aliases ([1]) in Docker Compose, but those names are only visible inside the compose network, meaning you have to set the `Host` header from outside the netns, which is a hassle I don't want to inflict on demo users. - Having a distinct service for assets is convenient because we can make it depend on `pair_aggregators`. If that ran last, it could cause `docker compose up --wait` to fail (see comment in `compose.yaml`). [1]: https://docs.docker.com/compose/compose-file/05-services/#aliases Part of #1096
tgeoghegan
force-pushed
the
timg/compose-vite
branch
from
0a832eb
to
939b62b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want demo users to be able to get started with nothing but a
divviupbinary, a working Docker Compose install andcompose.yaml.divviup_api_viterelies on having a local checkout of the static assets to serve. We now use thediviup_api_integration_testimage to serve static assets from servicestatic_assets. The assets in question are already present in the image being run in servicedivviup_api, but I did it this way for the following reasons:divviup-apiroutes requests to the static asset handler based on hostname, making it difficult to serve alongside the API. I tried creating some aliases (1) in Docker Compose, but those names are only visible inside the compose network, meaning you have to set theHostheader from outside the netns, which is a hassle I don't want to inflict on demo users.pair_aggregators. If that ran last, it could causedocker compose up --waitto fail (see comment incompose.yaml).Part of #1096