Do not compare preparation states in non-test code. #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required a few updates to non-test code: * The aggregation job creator used equality checks to determine if a given report aggregation was in state `START`. These are easily replaced by a call to `matches!`, which does not require `PartialEq + Eq`. * Checking if a repeated aggregation job `PUT` matched the preexisting aggregation job checked if the report aggregations were equal. This is replaced by populating the last request hash for initialization requests (as well as continuation requests) and checking if the aggregation job is equal; since the aggregation job carries both the round number as well as the request hash, this should suffice to check that the requests are equal. As a bonus, we no longer need to read the preexisting report aggregations.
branlwyd
added
the
allow-changed-migrations
inahga
approved these changes
Sep 5, 2023
|
(removing resolution of divviup/libprio-rs#722 as that issue is for libprio-rs, and we should do the work to remove comparability of relevant types from libprio-rs before counting that issue done. this is just the application-level change allowing the libprio-rs change to be made.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a few updates to non-test code:
The aggregation job creator used equality checks to determine if a given report aggregation was in state
START. These are easily replaced by a call tomatches!, which does not requirePartialEq + Eq.Checking if a repeated aggregation job
PUTmatched the preexisting aggregation job checked if the report aggregations were equal. This is replaced by populating the last request hash for initialization requests (as well as continuation requests) and checking if the aggregation job is equal; since the aggregation job carries both the round number as well as the request hash, this should suffice to check that the requests are equal. As a bonus, we no longer need to read the preexisting report aggregations.