Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes for DAP-07 #1923

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Minor changes for DAP-07 #1923

merged 3 commits into from
Sep 15, 2023

Conversation

tgeoghegan
Copy link
Contributor

See individual commits

@tgeoghegan tgeoghegan requested a review from a team as a code owner September 14, 2023 00:46
@tgeoghegan tgeoghegan mentioned this pull request Sep 14, 2023
Closed
11 tasks
@inahga
Copy link
Contributor

inahga commented Sep 14, 2023

We should probably update the README to indicate main is targeting DAP-06, and perhaps that DAP-05 is not planned?

inahga
inahga approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@inahga inahga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

Base automatically changed from timg/round-to-step to main September 14, 2023 20:24
@tgeoghegan
Copy link
Contributor Author

We should probably update the README to indicate main is targeting DAP-06, and perhaps that DAP-05 is not planned?

Yeah, fixing the readme is in my TODO list in #1669. But there's no reason not to do it here, especially since Chris Patton helpfully pushed DAP-07 today.

@tgeoghegan tgeoghegan changed the title Minor changes for DAP-06 Minor changes for DAP-07 Sep 14, 2023
@tgeoghegan tgeoghegan enabled auto-merge (squash) September 14, 2023 23:43
@tgeoghegan tgeoghegan merged commit 214446b into main Sep 15, 2023
7 checks passed
@tgeoghegan tgeoghegan deleted the timg/dap-06-minor-stuff branch September 15, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inahga inahga inahga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgeoghegan @inahga