Fixup garbage-collection-check clause of put_report_aggregation. #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and put_leader_report_aggregation. The condition here was reversed, only allowing a non-expired report aggregation row to be updated by the put operations. In practice, this wasn't a problem, as in application code put_report_aggregation was always paired with put_aggregation_job, and the condition on put_aggregation_job was correct.
|
(see also #2810 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and put_leader_report_aggregation. The condition here was reversed, only allowing a non-expired report aggregation row to be updated by the put operations. In practice, this wasn't a problem, as in application code put_report_aggregation was always paired with put_aggregation_job, and the condition on put_aggregation_job was correct.