Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYD support #12

Merged
merged 7 commits into from
Jun 2, 2024
Merged

CYD support #12

merged 7 commits into from
Jun 2, 2024

Conversation

ATOMNFT
Copy link
Contributor

@ATOMNFT ATOMNFT commented May 29, 2024

I have added the SSD1306 and WEMOS_OLED_SHIELD back into the files. Sketch contains all displays and now includes CYD.

minigotchi-ESP32/config.cpp Outdated Show resolved Hide resolved
minigotchi-ESP32/display.cpp Show resolved Hide resolved
minigotchi-ESP32/display.cpp Outdated Show resolved Hide resolved
minigotchi-ESP32/display.h Show resolved Hide resolved
Copy link
Owner

@dj1ch dj1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need to clean up the code a little, then I think we'll be good to merge.

minigotchi-ESP32/display.h Outdated Show resolved Hide resolved
minigotchi-ESP32/display.cpp Outdated Show resolved Hide resolved
minigotchi-ESP32/display.h Show resolved Hide resolved
@@ -6,6 +6,7 @@
#define CONFIG_H

#include <Arduino.h>
#include <TFT_eSPI.h>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need that here, it's all in display.*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@dj1ch dj1ch changed the title Replaced Original Code CYD support Jun 2, 2024
@dj1ch dj1ch merged commit eb1d8e8 into dj1ch:main Jun 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants