Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log out user menu on Django 5.0 #512

Merged

Conversation

erkesado
Copy link
Contributor

Fixes #509

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1428c0d) 100.00% compared to head (fa46bb2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just tested and looks perfect. Good job!

@erkesado
Copy link
Contributor Author

@fsbraun I'm glad that it works :D

@fsbraun
Copy link
Member

fsbraun commented Jan 26, 2024

@erkesado Frankly, I was hoping for more common styles between <a> and <button>. Now, that you've done, it seems less transparent to me. Sorry, I was pointing you in the wrong direction.
Can you go back one commit to c49ddcb96c7438861c94c58634f7b1aa252578a7 (git reset HEAD~1 && git push --force, I believe)?

@marksweb marksweb changed the title fix: "Django administration > Log out user" menu is not working on Django 5.0 fix: Log out user menu on Django 5.0 Jan 26, 2024
@erkesado erkesado force-pushed the fix/Django-administration/Logout-user branch from dba255b to fa46bb2 Compare January 27, 2024 05:33
@erkesado
Copy link
Contributor Author

@fsbraun I restored the initial commit

@fsbraun fsbraun merged commit d7dcfba into django-cms:master Jan 27, 2024
21 checks passed
@erkesado erkesado deleted the fix/Django-administration/Logout-user branch January 27, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Django administration > Logout user" leads to a 405 error (Method Not Allowed (GET): /en/admin/logout/)
2 participants