Feat: django 4.2 support #123
Conversation
|
BTW: If it is considered bad, to open a pull request for this instead of integrating the changes into the existing pull request #120 , we can gladly close this one. But I don't know how to append commits to a foreign pull request. |
|
@mogoh while you've got an open PR it just shows what's happening on your branch here. You can rebase your branch and keep making changes. They'll all just show up here. If the branch isn't ready yet, you can also have draft PRs. This gives people visibility of what you're doing but let's them know it's not ready to merge yet. |
|
@marksweb I did not know about draft pull requests, and now I changed this one into a draft. Thanks. |
mogoh
force-pushed
the
feat-django-4-2-support
branch
3 times, most recently
from
ec48b45
to
31e5eef
Compare
Using latest cms migration as a dependency. Co-authored-by: Vašek Chalupníček <[email protected]> Co-authored-by: Mark Walker <[email protected]>
mogoh
force-pushed
the
feat-django-4-2-support
branch
from
31e5eef
to
aa86407
Compare
use ruff instead of flake8 and isort
mogoh
force-pushed
the
feat-django-4-2-support
branch
from
aa86407
to
f4f7811
Compare
mogoh
force-pushed
the
feat-django-4-2-support
branch
2 times, most recently
from
436783e
to
2baa8c6
Compare
mogoh
force-pushed
the
feat-django-4-2-support
branch
from
2baa8c6
to
c917c21
Compare
|
This pull request is now ready for review. |
Python version on par with supported versions. Co-authored-by: Mark Walker <[email protected]>
|
I guess I missed something. |
|
@mogoh Don't worry about changing version. We have dedicated PRs to handle the version change, and the release process for this needs updating so I can do that as it needs changes on pypi as well if I've not set it up already. |
|
@mogoh I should add to that, we usually reserve a header in changelogs for "unreleased" that you can then add the PR changes to, and once there are changes ready for a release, all unreleased changes get moved to a heading and date for the new version that's getting released. Some projects use a tool called |
* feat: Add migrations for Django 4.2 Using latest cms migration as a dependency. Co-authored-by: Vašek Chalupníček <[email protected]> Co-authored-by: Mark Walker <[email protected]> * build: update setup.py classifiers * test: add script to autogenerate requirements * test: rename base.txt into requirements.in and add some changes * test: delete old test requirements * test: autogenerate requirements * ci: add pyproject.toml * ci: Update tox.ini use ruff instead of flake8 and isort * ci: linting on push / pull_reqest now uses ruff instead of flake8 and isort * ci: add .pre-commit-config.yaml * ci: add lint-pr.yml * ci: update test.yml * fix: sort imports * docs: update CHANGELOG.rst * ci: relax coverage requirements down to 95% * ci: Update .pre-commit-config.yaml Python version on par with supported versions. Co-authored-by: Mark Walker <[email protected]> --------- Co-authored-by: Vašek Chalupníček <[email protected]> Co-authored-by: Mark Walker <[email protected]> Co-authored-by: Leonhard Küper <[email protected]>
Description
I just wanted to create a pull request for discussing progress.
Even though I am at an OK level of using git, I am not that familiar with github specific pull requests.
So, if I understood that correctly, I can still rebase the branch before merging.
This pull request is for issue #122 .
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.