Avoid patch on RelationshipView deleting relationship instance when constraint would allow null
#499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alig1493
changed the title
Alig1493
force-pushed
the
relationship_view_patch
branch
2 times, most recently
from
187057f
to
e3c66b0
Compare
sliverc
requested changes
Oct 23, 2018
Alig1493
force-pushed
the
relationship_view_patch
branch
from
1fe5206
to
575742b
Compare
|
@sliverc I applied the suggested changes. |
Alig1493
force-pushed
the
relationship_view_patch
branch
from
575742b
to
6cb56d3
Compare
sliverc
requested changes
Oct 24, 2018
example/tests/test_views.py
Outdated
| 'id': str(self.second_comment.id) | ||
| } | ||
| ], | ||
| 'links': {'self': 'http://testserver/authors/{}/relationships/comment_set'.format(self.author.id)} |
There was a problem hiding this comment.
./example/tests/test_views.py:246:101: E501 line too long (110 > 100 characters)
example/tests/test_views.py
Outdated
| 'id': str(comment.id) | ||
| } | ||
| ], | ||
| 'links': {'self': 'http://testserver/authors/{}/relationships/comment_set'.format(self.author.id)} |
There was a problem hiding this comment.
/example/tests/test_views.py:259:101: E501 line too long (110 > 100 characters)
|
master is now fixed after merging #501 so a rebase to master will fix the other linting issues. |
Alig1493
force-pushed
the
relationship_view_patch
branch
from
a125db9
to
31967bb
Compare
|
@sliverc I have rebased and pushed. |
sliverc
changed the title
RelationshipView deleting relationship instance when constraint would allow null
sliverc
force-pushed
the
relationship_view_patch
branch
from
31967bb
to
bbdaa8c
Compare
…h accordingly and updated relationship functionality for related fields
sliverc
force-pushed
the
relationship_view_patch
branch
2 times, most recently
from
368abde
to
ea6cbfc
Compare
sliverc
approved these changes
Oct 25, 2018
sliverc
force-pushed
the
relationship_view_patch
branch
from
ea6cbfc
to
46a386e
Compare
|
@Alig1493 Thanks. Added missing changelog entry and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242
Description of the Change
Added test to check for relationship view relationship types and patch accordingly and updated relationship functionality for related fields
Checklist
CHANGELOG.mdAUTHORS