Root path for websockets #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro R. Sedeño <[email protected]> Signed-off-by: Alejandro R Sedeño <[email protected]>
Signed-off-by: Alejandro R. Sedeño <[email protected]> Signed-off-by: Alejandro R Sedeño <[email protected]>
asedeno
force-pushed
the
root-path-for-websockets
branch
from
98dc7e2
to
cecd476
Compare
There was a problem hiding this comment.
OK, this looks good. Thanks @asedeno. We'll pull this in.
(I just need to look at that, unrelated, CI failure.)
|
Thanks @asedeno! 🎁 Just to let you know, I'll continue working on Daphne to get a release out, and then cut back to Channels for the matching PR there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #125, this adds root_path handing to Daphne's websocket protocol, similar to how it's handled in http.