Read only error when running mu4e-view-rendered-hook

[thierryvolpiatto]

Describe the bug

The hook mu4e-view-rendered-hook runs outside the inhibit-read-only let body hence this error:

error in process filter: smiley-buffer: Buffer is read-only: #<buffer mu4e-article>

advising smiley-buffer which is added to mu4e-view-rendered-hook in my config fixes the bug.

How to Reproduce

Add smiley-buffer to mu4e-view-rendered-hook.

Environment

LinuxMint, emacs-28

Checklist

• [ X] you are running either an 1.8.x/1.10.x release or master (otherwise please upgrade)
• [ X] you can reproduce the problem without 3rd party extensions (including Doom/Evil, various extensions etc.)
• [ X] you have read all of the above

[thierryvolpiatto]

Probably this patch fixes it (fully not tested):

diff --git a/mu4e/mu4e-view.el b/mu4e/mu4e-view.el
index ce71d17a..0b0b31e0 100644
--- a/mu4e/mu4e-view.el
+++ b/mu4e/mu4e-view.el
@@ -651,7 +651,8 @@ As a side-effect, a message that is being viewed loses its
         (mu4e-error "Cannot get a message view"))
       (select-window mu4e~headers-view-win)))
   (with-current-buffer gnus-article-buffer
-    (run-hooks 'mu4e-view-rendered-hook)))
+    (let ((inhibit-read-only t))
+      (run-hooks 'mu4e-view-rendered-hook))))
 
 (defun mu4e-view-message-text (msg)
   "Return the pristine MSG as a string."

[djcb]

Yeah, making it read-write is probably the more useful behavior. I'll push a fix.