Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Linter] False positive on H037 #679

Closed
3 tasks done
malo-malo opened this issue Jun 2, 2023 · 2 comments · Fixed by #681
Closed
3 tasks done

[BUG] [Linter] False positive on H037 #679

malo-malo opened this issue Jun 2, 2023 · 2 comments · Fixed by #681
Labels
🔍 linter 🦠 bug Something isn't working released

Comments

@malo-malo
Copy link

System Info

  • OS: ubuntu 20.04
  • Python Version 3.8.10
  • djLint Version 1.30.0
  • template language: django templates

Issue

I get a false positive of H037 Duplicate attribute found on a rect tag with both x and rx attributes.

How To Reproduce

Here is a minimal reproduction :

<rect x="2" y="3" rx="1" />

Contents of .djlintrc/pyproject.toml [tool.djlint]

[tool.djlint]
require_pragma = true
profile = "django"
custom_blocks = "..."
custom_html = "..."
blank_line_after_tag = "extends, endblock"
max_line_length = 120
ignore = "H021,H023,H030,H031"
@malo-malo malo-malo added 🔍 linter 🦠 bug Something isn't working labels Jun 2, 2023
@christopherpickering
Copy link
Contributor

Thanks for catching... beginners mistake 😄 I will fix in the next release.

christopherpickering added a commit that referenced this issue Jun 2, 2023
@christopherpickering
fix(linter): fixed false positive on H037
3b2e522 
closes #679
@christopherpickering christopherpickering mentioned this issue Jun 2, 2023
Merged
2 tasks
christopherpickering pushed a commit that referenced this issue Jun 2, 2023
@semantic-release-bot
chore(release): 1.30.1 [skip ci]
939155c 
## [1.30.1](v1.30.0...v1.30.1) (2023-06-02)

### Bug Fixes

* **linter:** added missing positive on H021 ([221c31f](221c31f)), closes [#678](#678)
* **linter:** fixed false positive on H037 ([3b2e522](3b2e522)), closes [#679](#679)
@christopherpickering
Copy link
Contributor

🎉 This issue has been resolved in version 1.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔍 linter 🦠 bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): fixed false positive on H037 djlint/djLint
2 participants
@christopherpickering @malo-malo