Fix missed H025 for double closing HTML tags #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for djlint canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 95.47% 95.48%
=======================================
Files 16 16
Lines 1061 1062 +1
Branches 283 283
=======================================
+ Hits 1013 1014 +1
Misses 33 33
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
@MrkGrgsn thanks for this! |
|
🎉 This PR is included in version 1.34.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't see any reason to keep orphaned closing tags in
open_tagsso store them separately to avoid accidental matches against subsequent closing tags.Pull Request Check List
Resolves: #786