Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

fix flickering #350

Closed
wants to merge 5 commits into from
Closed

fix flickering #350

wants to merge 5 commits into from

Conversation

sevz17
Copy link
Collaborator

@sevz17 sevz17 commented Dec 6, 2022

Before merging, make sure #349 is fixed.

Fixes: #306

@sevz17 sevz17 marked this pull request as ready for review December 7, 2022 22:42
@sevz17
Copy link
Collaborator Author

sevz17 commented Dec 7, 2022

@Job79, @PalanixYT, can you test this?

@Job79
Copy link
Contributor

Job79 commented Dec 8, 2022

Can no longer reproduce the "freeze" issue from #349 when applying this pull request

@Job79
Copy link
Contributor

Job79 commented Dec 9, 2022

Have been using this patch for 2 days now, never experienced any freezes. But I did see some flickering when resizing / opening alacritty. There is no flickering when using foot / chromium, so this is probably an alactitty problem?

@sevz17 sevz17 mentioned this pull request Dec 10, 2022
Closed
@sevz17
Copy link
Collaborator Author

sevz17 commented Dec 10, 2022

Have been using this patch for 2 days now, never experienced any freezes. But I did see some flickering when resizing / opening alacritty. There is no flickering when using foot / chromium, so this is probably an alactitty problem?

Not really, this is hackish, we should listen to the commit event, not ack_configure, but some clients do not call wl_surface.commit when we resize them with the same size (and this is ok, they are not obligated to do it), wl_surface.commit must be called after submitting a new buffer (e.g because it changed its size, its content, etc), ack_configure is just to let us know that they received the configure (new size) event (at this moment they aren't obligated to submit a new buffer)

@sevz17
disable client's scene node after create it
1de48c9 
will be enabled when setting up its monitor and arrange it

Bug: djpohly#306
@sevz17
do not listen to the commit event
ce2aec0 
instead listen to the ack_configure event, it is not ideal but some clients
(e.g a wlroots-based compositor in wayland backend) do not call
wl_surface.commit after an empty configure, e.g call
wlr_xdg_toplevel_set_size() with the same width and height.

Bug: djpohly#306
@sevz17
schedule an output frame after a suface acking a configure
df30c95 
this to make sure the change of `c->resize` is taken into account
@sevz17 sevz17 mentioned this pull request Dec 12, 2022
Closed
@sevz17
Copy link
Collaborator Author

sevz17 commented Dec 16, 2022

Superseded by #357 and #363

@sevz17 sevz17 closed this Dec 16, 2022
@sevz17 sevz17 deleted the flick branch December 16, 2022 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flickering when modifying main area's ratio
2 participants
@sevz17 @Job79