Merge pull request #107 from djrrb/vertical-glyph-metrics

Implement "proper" vertical glyph metrics
djrrb · Nov 30, 2023 · 540c2aa · 540c2aa
2 parents 6d2f645 + a40dddc
commit 540c2aa
Show file tree

Hide file tree

Showing 1,067 changed files with 3,343 additions and 1,044 deletions.
diff --git a/scripts/assembleRotatedSources.py b/scripts/assembleRotatedSources.py
@@ -163,6 +163,12 @@ def main():
         print("assembling", outputPath.name)
 
         outputFont.info = deepcopy(rotatedSourceFont.info)
+        for fieldName in [
+            "openTypeVheaVertTypoAscender",
+            "openTypeVheaVertTypoDescender",
+            "openTypeVheaVertTypoLineGap",
+        ]:
+            delattr(outputFont.info, fieldName)
         outputFont.info.familyName = familyName
         outputFont.lib["public.glyphOrder"] = glyphOrder
         outputFont.groups = rotatedSourceFont.groups
@@ -225,4 +231,5 @@ def main():
         outputFont.save(outputPath, overwrite=True)
 
 
-main()
+if __name__ == "__main__":
+    main()
diff --git a/sources/1-drawing/Bungee-Regular.ufo/features.fea b/sources/1-drawing/Bungee-Regular.ufo/features.fea
@@ -2,7 +2,6 @@
 include(features/classes.fea);
 include(features/features.fea);
 # vertical features
-include(features/vpal.fea);
 include(features/vertical.fea);
 include(features/blocks.fea);
 include(features/vkrn.fea);
diff --git a/sources/1-drawing/Bungee-Regular.ufo/fontinfo.plist b/sources/1-drawing/Bungee-Regular.ufo/fontinfo.plist
@@ -122,9 +122,9 @@
     <key>openTypeOS2WidthClass</key>
     <integer>5</integer>
     <key>openTypeVheaVertTypoAscender</key>
-    <integer>860</integer>
+    <integer>500</integer>
     <key>openTypeVheaVertTypoDescender</key>
-    <integer>140</integer>
+    <integer>-500</integer>
     <key>openTypeVheaVertTypoLineGap</key>
     <integer>0</integer>
     <key>postscriptBlueValues</key>

diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="A" format="2">
-  <advance width="730"/>
+  <advance height="1000" width="730"/>
   <unicode hex="0041"/>
   <outline>
     <contour>
@@ -52,4 +52,10 @@
       <point x="273" y="11"/>
     </contour>
   </outline>
+  <lib>
+    <dict>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
+    </dict>
+  </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.s_v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.s_v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="A.s_v" format="2">
-  <advance width="1000"/>
+  <advance height="809" width="1000"/>
   <unicode hex="E246"/>
   <outline>
     <contour>
@@ -64,6 +64,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0.5,0,0.5,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>742</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.salt.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.salt.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="A.salt" format="2">
-  <advance width="736"/>
+  <advance height="1000" width="736"/>
   <unicode hex="E100"/>
   <anchor x="368" y="747" name="top"/>
   <anchor x="368" y="0" name="bottom"/>
@@ -52,6 +52,8 @@
       <string>DJR</string>
       <key>org.robofab.postScriptHintData</key>
       <dict/>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.salt_s_v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.salt_s_v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="A.salt_s_v" format="2">
-  <advance width="1000"/>
+  <advance height="819" width="1000"/>
   <unicode hex="E259"/>
   <outline>
     <contour>
@@ -52,6 +52,8 @@
       <dict/>
       <key>public.markColor</key>
       <string>0.5,0,0.5,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>752</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.salt_v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.salt_v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="A.salt_v" format="2">
-  <advance width="1000"/>
+  <advance height="860" width="1000"/>
   <unicode hex="E1ED"/>
   <anchor x="499" y="747" name="top"/>
   <anchor x="499" y="747" name="top"/>
@@ -58,6 +58,8 @@
       <string>DJR</string>
       <key>org.robofab.postScriptHintData</key>
       <dict/>
+      <key>public.verticalOrigin</key>
+      <integer>793</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_.v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="A.v" format="2">
-  <advance width="1000"/>
+  <advance height="849" width="1000"/>
   <unicode hex="FF21"/>
   <outline>
     <contour>
@@ -68,6 +68,8 @@
       <string>DJR</string>
       <key>org.robofab.postScriptHintData</key>
       <dict/>
+      <key>public.verticalOrigin</key>
+      <integer>782</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="AE" format="2">
-  <advance width="1005"/>
+  <advance height="1000" width="1005"/>
   <unicode hex="00C6"/>
   <outline>
     <contour>
@@ -79,6 +79,8 @@
       <string>2011-07-29 22:49:52</string>
       <key>com.fontbureau.modifiedBy</key>
       <string>DJR</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.salt.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.salt.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="AE.salt" format="2">
-  <advance width="1013"/>
+  <advance height="1000" width="1013"/>
   <unicode hex="E135"/>
   <outline>
     <contour>
@@ -67,6 +67,8 @@
       <string>2011-08-09 19:56:19</string>
       <key>com.fontbureau.modifiedBy</key>
       <string>DJR</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.salt_v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.salt_v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="AE.salt_v" format="2">
-  <advance width="1000"/>
+  <advance height="872" width="1000"/>
   <unicode hex="E224"/>
   <outline>
     <contour>
@@ -67,6 +67,8 @@
       <string>2011-08-09 19:56:19</string>
       <key>com.fontbureau.modifiedBy</key>
       <string>DJR</string>
+      <key>public.verticalOrigin</key>
+      <integer>792</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_E_.v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="AE.v" format="2">
-  <advance width="1000"/>
+  <advance height="872" width="1000"/>
   <unicode hex="E1E0"/>
   <outline>
     <contour>
@@ -81,6 +81,8 @@
       <string>DJR</string>
       <key>org.robofab.postScriptHintData</key>
       <dict/>
+      <key>public.verticalOrigin</key>
+      <integer>792</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Aacute" format="2">
-  <advance width="730"/>
+  <advance height="1000" width="730"/>
   <unicode hex="00C1"/>
   <outline>
     <component base="A"/>
@@ -10,6 +10,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.salt.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.salt.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Aacute.salt" format="2">
-  <advance width="736"/>
+  <advance height="1000" width="736"/>
   <unicode hex="E102"/>
   <outline>
     <component base="A.salt"/>
@@ -14,6 +14,8 @@
       <string>DJR</string>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.salt_v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.salt_v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Aacute.salt_v" format="2">
-  <advance width="1000"/>
+  <advance height="1015" width="1000"/>
   <unicode hex="E1EF"/>
   <outline>
     <component base="acute" xOffset="250" yOffset="-40"/>
@@ -14,6 +14,8 @@
       <string>DJR</string>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>948</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_acute.v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Aacute.v" format="2">
-  <advance width="1000"/>
+  <advance height="1015" width="1000"/>
   <unicode hex="E18B"/>
   <outline>
     <component base="A.s_v"/>
@@ -14,6 +14,8 @@
       <string>DJR</string>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>948</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abreve" format="2">
-  <advance width="730"/>
+  <advance height="1000" width="730"/>
   <unicode hex="0102"/>
   <outline>
     <component base="A"/>
@@ -10,6 +10,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.salt.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.salt.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abreve.salt" format="2">
-  <advance width="736"/>
+  <advance height="1000" width="736"/>
   <unicode hex="E108"/>
   <outline>
     <component base="A.salt"/>
@@ -10,6 +10,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.salt_v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.salt_v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abreve.salt_v" format="2">
-  <advance width="1000"/>
+  <advance height="1031" width="1000"/>
   <unicode hex="E1F5"/>
   <outline>
     <component base="A.salt_s_v"/>
@@ -14,6 +14,8 @@
       <string>DJR</string>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>964</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.v.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breve.v.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abreve.v" format="2">
-  <advance width="1000"/>
+  <advance height="1031" width="1000"/>
   <unicode hex="E191"/>
   <outline>
     <component base="A.s_v"/>
@@ -14,6 +14,8 @@
       <string>DJR</string>
       <key>public.markColor</key>
       <string>0,0.5,0,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>964</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breveacute.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_breveacute.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abreveacute" format="2">
-  <advance width="730"/>
+  <advance height="1000" width="730"/>
   <unicode hex="1EAE"/>
   <outline>
     <component base="A"/>
@@ -10,6 +10,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0.5,1,0.5,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_brevedotbelow.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_brevedotbelow.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abrevedotbelow" format="2">
-  <advance width="730"/>
+  <advance height="1000" width="730"/>
   <unicode hex="1EB6"/>
   <outline>
     <component base="Abreve"/>
@@ -10,6 +10,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0.5,1,0.5,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>
diff --git a/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_brevegrave.glif b/sources/1-drawing/Bungee-Regular.ufo/glyphs/A_brevegrave.glif
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <glyph name="Abrevegrave" format="2">
-  <advance width="730"/>
+  <advance height="1000" width="730"/>
   <unicode hex="1EB0"/>
   <outline>
     <component base="A"/>
@@ -10,6 +10,8 @@
     <dict>
       <key>public.markColor</key>
       <string>0.5,1,0.5,0.5</string>
+      <key>public.verticalOrigin</key>
+      <integer>860</integer>
     </dict>
   </lib>
 </glyph>