Merge pull request nightscout#4 from nightscout/master

update to latest

.github/ISSUE_TEMPLATE/--bug-report.md

@@ -0,0 +1,29 @@
+---
+name: "\U0001F41BBug report"
+about: Create a report to help us improve things
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Your setup information**
+- What version of Nightscout (e.g. 0.10.3)
+- What type of CGM, and how do you get your data there? (e.g. G4 and ShareBridge, or wired receiver, etc.)
+- Is your issue specific to a browser (Firefox/Safari/Chrome?) or a device (Android phone, etc.)?
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/--feature-request--.md

@@ -0,0 +1,17 @@
+---
+name: "\U0001F4A1Feature request\U0001F4A1"
+about: Suggest an idea for this project
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/--individual-troubleshooting-help.md

@@ -0,0 +1,16 @@
+---
+name: "\U0001F198Individual troubleshooting help"
+about: Getting help with your own individual setup of Nightscout
+
+---
+
+Having issues getting Nightscout up and running? Instead of creating an issue here, please use one of the existing support channels for Nightscout.
+
+The main support channel is on Facebook: please join the CGM In The Cloud Facebook group (https://www.facebook.com/groups/cgminthecloud) and start a post there. 
+
+**Suggestions to include in your post when you are asking for help:**
+1. Include what you are trying to do: ("*I am trying to set up Nightscout for the first time.*")
+2. Include which step you are on and what the problem is: ("*I deployed on Heroku, but I'm not seeing any BG data.*")
+3. If possible, include a link to the version of documentation you are following ("*I'm following the OpenAPS Nightscout setup docs (https://openaps.readthedocs.io/en/latest/docs/While%20You%20Wait%20For%20Gear/nightscout-setup.html#nightscout-setup-with-heroku)*")
+
+Other places you can find support and assistance for Nightscout include Gitter's [nightscout/public](https://gitter.im/nightscout/public) channel.

CONTRIBUTING.md

@@ -36,14 +36,16 @@
 [waffle]: https://waffle.io/nightscout/cgm-remote-monitor
 [progress-img]: https://badge.waffle.io/nightscout/cgm-remote-monitor.svg?label=in+progress&title=In+Progress
 
-## Design
+## Design & new features
 
-Participate in the design process by creating an issue to discuss your
-design.
+If you intend to add a new feature, please allow the community to participate in the design process by creating an issue to discuss your design. For new features, the issue should describe what use cases the new feature intends to solve, or which existing use cases are being improved.
+
+Note Nighscout has a plugin architecture for adding new features. We expect most code for new features live inside a Plugin, so the code retains a clear separation of concerns. If the Plugin API doesn't implement all features you need to implement your feature, please discuss with us on adding those features to the API. Note new features should under almost no circumstances require changes to the existing plugins.
 
 ## Develop on `dev`
 
-We develop on the `dev` branch.
+We develop on the `dev` branch. All new pull requests should be targeted to `dev`. The `master` branch is only used for distributing the latest version of the tested sources.
+
 You can get the dev branch checked out using `git checkout dev`.
 
 ## Style Guide
@@ -65,51 +67,49 @@ Some simple rules, that will make it easier to maintain our codebase:
   };
   ```
 
+If in doubt, format your code with `js-beautify --indent-size 2 --comma-first  --keep-array-indentation`
+
 ## Create a prototype
 
-Fork cgm-remote-monitor and create a branch.
-You can create a branch using `git checkout -b wip/add-my-widget`.
-This creates a new branch called `wip/add-my-widget`.  The `wip`
-stands for work in progress and is a common prefix so that when know
-what to expect when reviewing many branches.
+Fork cgm-remote-monitor and create a branch. You can create a branch using `git checkout -b wip/add-my-widget`. This creates a new branch called `wip/add-my-widget`.  The `wip` stands for work in progress and is a common prefix so that when know what to expect when reviewing many branches.
 
 ## Submit a pull request
 
-When you are done working with your prototype, it can be tempting to
-post on popular channels such as Facebook.  We encourage contributors
-to submit their code for review, debate, and release before announcing
-features on social media.
+When you are done working with your prototype, it can be tempting to post on popular channels such as Facebook.  We encourage contributors to submit their code for review, debate, and release before announcing features on social media.
+
+This can be done by checking your code `git commit -avm 'my improvements are here'`, the branch you created back to your own fork. This will probably look something like `git push -u origin wip/add-my-widget`.
+
+Now that the commits are available on github, you can click on the compare buttons on your fork to create a pull request.  Make sure to select [Nightscout's `dev` branch](https://github.com/nightscout/cgm-remote-monitor/tree/dev).
+
+We assume all new Pull Requests are at least smoke tested by the author and all code in the PR actually works.
+
+Please include a description of what the features do and rationalize why the changes are needed.
+
+If you add any new NPM module dependencies, you have to rationalize why there are needed - we prefer pull requests that reduce dependencies, not add them.
+
+When adding new features that add confugration options, please ensure the `README` document is amended with information on the new configuration.
+
+## Bug fixing
+
+If you've fixed a bug, please consider adding a unit test to the `/tests` folder that reproduces the original bug without the change.
 
-This can be done by checking your code `git commit -avm 'my
-improvements are here'`, the branch you created back to your own
-fork. This will probably look something like
-`git push -u origin wip/add-my-widget`.
+Try to identify the root cause of the issue and fix the issue. Pull requests that simply add null checks to hide issues are unlikely to be accepted.
 
-Now that the commits are available on github, you can click on the
-compare buttons on your fork to create a pull request.  Make sure to
-select [Nightscout's `dev` branch](https://github.com/nightscout/cgm-remote-monitor/tree/dev).
+Please include instructions how to test the changes.
 
 ## Comments and issues
 
-We encourage liberal use of the comments, including images where
-appropriate.
+We encourage liberal use of the comments, including images where appropriate.
 
 ## Co-ordination
 
-Most cgm-remote-monitor hackers use github's ticketing system, along with Facebook cgm-in-the-cloud, and
-gitter.
+Most cgm-remote-monitor hackers use github's ticketing system, along with Facebook cgm-in-the-cloud, and gitter.
 
-We use git-flow, with `master` as our production, stable branch, and
-`dev` is used to queue up for upcoming releases.  Everything else is
-done on branches, hopefully with names that indicate what to expect.
+We use git-flow, with `master` as our production, stable branch, and `dev` is used to queue up for upcoming releases.  Everything else is done on branches, hopefully with names that indicate what to expect.
 
-Once `dev` has been reviewed and people feel it's time to release, we
-follow the git-flow release process, which creates a new tag and bumps
-the version correctly.  See sem-ver for versioning strategy.
+Once `dev` has been reviewed and people feel it's time to release, we follow the git-flow release process, which creates a new tag and bumps the version correctly.  See sem-ver for versioning strategy.
 
-Every commit is tested by travis.  We encourage adding tests to
-validate your design.  We encourage discussing your use cases to help
-everyone get a better understanding of your design.
+Every commit is tested by travis.  We encourage adding tests to validate your design.  We encourage discussing your use cases to help everyone get a better understanding of your design.
 
 ## Other Dev Tips
 

lib/language.js

@@ -10237,7 +10237,7 @@ function init() {
     ,'BWP' : { // Bolus Wizard Preview
       cs: 'KALK'
       ,he: 'BWP'
-      ,de: 'Bolus-Kalkulator Vorschau'
+      ,de: 'BWP'
       ,dk: 'Bolusberegner (BWP)'
       ,ro: 'Ajutor bolusare (BWP)'
       ,ru: 'Предпросмотр калькулятора болюса'

lib/plugins/xdrip-js.js

@@ -234,8 +234,8 @@ function init(ctx) {
 
     // session start is only valid if in a session
     if (sensor && sensor.lastSessionStart && (sensor.lastState != 0x1)) {
-      let diffTime = moment().diff(moment(sensor.lastSessionStart));
-      let duration = moment.duration(diffTime);
+      var diffTime = moment().diff(moment(sensor.lastSessionStart));
+      var duration = moment.duration(diffTime);
 
       sessionDuration = duration.days() + ' days ' + duration.hours() + ' hours';