Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 11051 - Unmatched case in a final switch should throw in both release and non-release mode #14841

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jan 21, 2023

Reboot of #6095 so far just fixing merge failure.

Keep a HALT instruction in a final switch statement if the function is @safe and -release mode is enabled.

Keep a HALT instruction in a final switch statement if
the function is @safe and -release mode is enabled.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11051 major Unmatched case in a final switch should throw in both release and non-release mode

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14841"

@ntrel ntrel changed the title Fix issue 11051 Fix issue 11051 - Unmatched case in a final switch should throw in both release and non-release mode Jan 21, 2023
@AndrejMitrovic
Copy link
Contributor

Thanks @ntrel, I'll close the other PR.

@ntrel ntrel marked this pull request as ready for review January 23, 2023 17:56
@ntrel
Copy link
Contributor Author

ntrel commented Jan 23, 2023

The tests were all passing except circleci found 2 core dump files, see:
https://app.circleci.com/pipelines/github/dlang/dmd/24135/workflows/50b27a55-a64d-464c-a01e-1f8d354c7450/jobs/51690

So I have disabled generating core dumps with ulimit.

@RazvanN7 RazvanN7 merged commit 49771d7 into dlang:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants