Skip to content

Commit

Permalink
Remove GeneratorSettings.direct as it is never set
Browse files Browse the repository at this point in the history
  • Loading branch information
Geod24 authored and dlang-bot committed Jan 3, 2023
1 parent 0d42bb7 commit c66847d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion source/dub/generators/build.d
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class BuildGenerator : ProjectGenerator {
// perform the actual build
bool cached = false;
if (settings.rdmd) performRDMDBuild(settings, buildsettings, pack, config, target_path);
else if (settings.direct || !generate_binary) performDirectBuild(settings, buildsettings, pack, config, target_path);
else if (!generate_binary) performDirectBuild(settings, buildsettings, pack, config, target_path);
else cached = performCachedBuild(settings, buildsettings, pack, config, build_id, packages, additional_dep_files, target_path);

// HACK: cleanup dummy doc files, we shouldn't specialize on buildType
Expand Down
3 changes: 1 addition & 2 deletions source/dub/generators/generator.d
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ struct GeneratorSettings {
bool filterVersions;

// only used for generator "build"
bool run, force, direct, rdmd, tempBuild, parallelBuild;
bool run, force, rdmd, tempBuild, parallelBuild;

/// single file dub package
bool single;
Expand Down Expand Up @@ -1065,7 +1065,6 @@ const(string[string])[] makeCommandEnvironmentVariables(CommandType type,
env["DUB_COMBINED"] = settings.combined? "TRUE" : "";
env["DUB_RUN"] = settings.run? "TRUE" : "";
env["DUB_FORCE"] = settings.force? "TRUE" : "";
env["DUB_DIRECT"] = settings.direct? "TRUE" : "";
env["DUB_RDMD"] = settings.rdmd? "TRUE" : "";
env["DUB_TEMP_BUILD"] = settings.tempBuild? "TRUE" : "";
env["DUB_PARALLEL_BUILD"] = settings.parallelBuild? "TRUE" : "";
Expand Down

0 comments on commit c66847d

Please sign in to comment.