Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on std.xml #1939

Closed
shoo opened this issue May 2, 2020 · 4 comments · Fixed by #1977
Closed

Remove the dependency on std.xml #1939

shoo opened this issue May 2, 2020 · 4 comments · Fixed by #1977

Comments

@shoo
Copy link
Contributor

shoo commented May 2, 2020

In D 2.092.0, std.xml is marked as deprecated.
Since the dub uses std.xml, we need to remove this dependency.

There is only one place that depends on std.xml, which is as follows:

@rikkimax
Copy link
Contributor

rikkimax commented May 2, 2020

deprecated("Will be removed from Phobos in 2.101.0. If you still need it, go to https://github.com/DigitalMars/undeaD")

@andre2007
Copy link
Contributor

What would be a good solution? My first idea would be to copy the code of std.xml undead to source/dub/internal folder.

@rikkimax
Copy link
Contributor

rikkimax commented May 2, 2020

What would be a good solution? My first idea would be to copy the code of std.xml undead to source/dub/internal folder.

Add it as a dependency until somebody bothers with a rewrite. That is the simplest answer.

@andre2007
Copy link
Contributor

The xml parsing is replaced with std.regex:
#1977

@andre2007 andre2007 linked a pull request Jul 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants