-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of deprecated std.xml #1977
Conversation
Thanks for your pull request and interest in making D better, @andre2007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. |
I just noticed one other thing: before it would only search for |
You are right, I have to extend the regex to find |
I'm really not quite sold on the conversion to regex and manual string operations. XML could contain a lot more weird stuff like whitespace in the tags, random attributes, the tags being in a completely different nesting level (like in some sub-tags instead of the expected root tag) than expected, etc. How big would putting the entire undeaD xml package in be? |
3100 lines or 90kb. Should I add it? |
hm I don't think I should decide on that, what does @wilzbach think? |
@wilzbach should I add the whole undead.xml file, what do you think? |
Alternatively do what DCD and friends do. Git submodule for script (i.e. makefile) and dub dependency for dub. |
Hmm, I unfortunately don't see a better alternative as well. This really looks like the easiest solution to this problem as long as we don't trust dub enough to bootstrap itself or want to maintain easy bootstrapping of dub on new platforms. Though we should add a big comment on the header stating that it's dead code, link to the undead package and maybe even put it in under an undead folder as well? Re git submodules: I don't think it matters much whether it's a git submodule or just a copy/paste as I don't expect this file to change. The git submodule will require small adaptions to the CIs, build script and dub distro packages, but that's marginal as long as it's mentioned in a changelog entry. If no one else has a strong opinion, I would leave the final choice on copy/paste or git submodule to you. I'm fine either way. |
As the other dependencies are also code copies and in the long run we will have a better solution, when dub bootstrapping is available, I favour copying the file into it. |
macOS-10.15 LDC master fails due to an unrelated Vibe-d SSL linker issue: d_tls.a(vibe.stream.openssl.o) |
Ping :) |
In this case, parsing the xml with std.regex seems to make most sense.
Example XML