-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment variable DUB_PACKAGE_VERSION added #1562
Conversation
Thanks for your pull request and interest in making D better, @andre2007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. |
When I read the the title I thought that this was exposing the version of dub itself and not of the currently compiled package. I think a more descriptive name would be |
@ZombineDev done:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but needs a PR to dub-docs before it can be merged.
This will be a lot nice than e.g. this hack here: https://github.com/dlang-community/D-Scanner/blob/master/dub.json#L27 |
well it will sadly not be enough to fix it recompiling every time just yet, but useful nevertheless. |
Documents update dlang/dub-docs#7 PING :) |
The new environment variable DUB_PACKAGE_VERSION can be used in shell / batch scripts called from "preGenerateCommands". The version of the package can be written to module file.
This would simplify e.g. this logic https://github.com/dlang/dub/blob/master/build.cmd
Is a unit test needed for the new environment variable?