-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Regenerate buildSettings after preGenerateCommands #1708
Conversation
Thanks for your pull request, @wilzbach! |
@@ -2,6 +2,6 @@ | |||
"name": "generated-sources", | |||
"description": "Example of using pre generate commands to generate source code.", | |||
"preGenerateCommands": [ | |||
"echo int fun() { return 42; } > source/test.d" | |||
"echo 'int fun() { return 42; }' > source/test.d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the ticks added? I just tested it and the file test.d
is created as
'int fun() { return 42; }'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the ticks cause problems, at least on Windows.
@wilzbach
it works only the second time. |
Fixed in #2035 |
Fixes #1474
This fixes the problem, but obviously we should be smarter
TODO:
FWIW it looks like even with the simple hello world example the buildSettings regeneration is already regenerated 4 times before.