-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Deduplicate dflags and lflags #2016
Conversation
getPackageSuppliers already handles SkipPackageSuppliers.none correctly, no need for an extra check.
For some reason, dflags and lflags were not using the 'add' convenience function, which allows to deduplicate flags. As a result some flags, especially link flags which propagate upwards, ended up taking half of the command line length.
Thanks for your pull request, @Geod24! |
I believe that was also a pet peeves of yours @UplinkCoder |
But
should get As far as I can see, this operates on the wrong level and needs to be reverted. |
Look at the second screenshot: It is still duplicated. |
Yes, I've seen the screenshot, but that does not look like the outcome of the algorithm, but of some coincident external effect. |
By the way, I know how annoying it is to miss a release, but in this case it was quite lucky that it came too late for the latest release. It really shouldn't have gone to the stable branch ;-) |
Before:
After:
There are still some improvements needed (notice the duplicated
-L-framework
), but the diff / benefit ratio is already great.Packed in another tiny cleanup to avoid endless CI retriggers.
Targeting stable because I'm working on propagating dflags downwards and obviously this will come in handy.