Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

betterC flag enabled in generated visuald project file. Fixes #2024 #2025

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

MrZoraman
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @MrZoraman! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@thewilsonator
Copy link
Contributor

object.Exception@../tools/changed.d(254): Changelog entries should consist of one title line, a blank separator line, and a description.

Also there should be a test for this.

@PetarKirov
Copy link
Member

object.Exception@../tools/changed.d(254): Changelog entries should consist of one title line, a blank separator line, and a description.

I fixed the changelog title and rebased to master.

@Geod24 Geod24 merged commit ac6caf3 into dlang:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants