-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for '-platformlib' option. Fixes #2031 #2032
Conversation
Thanks for your pull request and interest in making D better, @dbankov-vmware! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. |
14f531d
to
bd5fccd
Compare
Please give a proper title and description to both PR and commits. Remember that:
Our contributing guidelines include an article about good commit messages which is well worth the read. |
This change adds the newly introduced LDC linker option '-platformlib' to the isLinkeDFlag(...) function in ldc.d so the option to be passed to LDC when invoked by DUB for linking.
bd5fccd
to
0cb21de
Compare
Updated title and description for both the PR and the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I looked at https://github.com/dlang/dub/blob/master/CONTRIBUTING.md before filing the PR which referred to https://github.blog/2013-01-22-closing-issues-via-commit-messages/ which left me with the impression that the commit message should include only 'Fixes...'.
Thanks for the feedback, I'll look at updating the contributing guide to make requirements clearer.
This change adds the newly introduced LDC linker option '-platformlib'
to the isLinkeDFlag(...) function in ldc.d so the option to be passed to
LDC when invoked by DUB for linking.