Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue #1673 (with dupe #1797 and #2019) #2034

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Correct issue #1673 (with dupe #1797 and #2019) #2034

merged 1 commit into from
Nov 17, 2020

Conversation

p0nce
Copy link
Contributor

@p0nce p0nce commented Nov 12, 2020

No description provided.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @p0nce! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case?

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, but as @thewilsonator please add a test for this.

@p0nce
Copy link
Contributor Author

p0nce commented Nov 13, 2020

Well I tested it locally.

@Geod24
Copy link
Member

Geod24 commented Nov 17, 2020

We really need to overhaul this test-suite. Let's not block improvements in the meantime.

@Geod24 Geod24 merged commit 78765f2 into dlang:master Nov 17, 2020
@p0nce
Copy link
Contributor Author

p0nce commented Nov 17, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants