-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for #2051 #2064
Hotfix for #2051 #2064
Conversation
Thanks for your pull request and interest in making D better, @drug007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. |
The PR makes |
It seems you removed an |
Ok, I'll do renaming in another PR then (to conform to other file names). |
a59968f
to
c652a76
Compare
before GeneratorSettings ignored this option
because it represents all package by definition
else dub doesn't find it because the single file package do not have the default package directory structure
no string processing to evaluate the result
to check if unit tests from the main source file run at all. Because by default the main source file is excluded from tests.
c652a76
to
d7fbf03
Compare
Rebased the branch |
@thewilsonator between what is preferable - many small specific commits like I did or one large commit like it was told in other PRs I saw? |
Specifically in this case, file renames in separate PRs is preferable. |
I've realized that GitHub is not able to handle renaming gracefully and shows both files separately that makes review very difficult. My question is more about is splitting a PR to many small commits better than one single large commit? For me it's much easier to review step by step by means of small, clean and dedicated commits than one large commit with all changes at once but I saw in other PRs the advice to squash all commits so I'm curious what approach is better here? |
Hot fix #2051