Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'linker-D-flag' detection for ldmd2 #2082

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jan 20, 2021

ldmd2 supports all ldc2 ones (and e.g. -link-defaultlib-shared is rather important).

Making these helper functions public will come in handy for reggae as well.

E.g., this is useful for Reggae too.
ldmd2 supports all ldc2 ones.
@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose this is not changelog-worthy as it's only beneficial for using dub as a library, rather than for end-users.

@PetarKirov PetarKirov added auto-merge dub-library-api Changes which affect dub's public library API labels Jan 21, 2021
@dlang-bot dlang-bot merged commit 24ca22d into dlang:master Jan 21, 2021
@PetarKirov
Copy link
Member

@kinke I suppose you guys can use the git-paths feature to depend on dub @ 24ca22d in reggae.

@PetarKirov PetarKirov added the libdc Changes which affect libdc - Dub's library for working with D compilers label Jan 21, 2021
@kinke kinke deleted the islinkerflag branch January 21, 2021 12:18
@kinke
Copy link
Contributor Author

kinke commented Jan 21, 2021

I suppose this is not changelog-worthy as it's only beneficial for using dub as a library, rather than for end-users.

The first commit, yes, the 2nd benefits normal usage with ldmd2 as well. I consider that more as a bug fix though, hence no changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge dub-library-api Changes which affect dub's public library API libdc Changes which affect libdc - Dub's library for working with D compilers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants