-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing run-unittest.sh by run-unittest.d. Inception #2084
Conversation
Thanks for your pull request and interest in making D better, @drug007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. |
5cee564
to
5501cb9
Compare
5501cb9
to
e485f42
Compare
I like your initiative here. There are a lot of shell scripts to convert, though :-) |
Thank you for your review! Yes, there is much work here but it can be done step-by-step. |
e485f42
to
3d9a1f3
Compare
@veelo I guess I shouldn't do forced push to keep the review? |
I think forced push is fine. I can still click "Show resolved" to see the review and your replies. It keeps the history short when merging without having to squash commits, which is nice. |
Ok, thanks for info. |
@drug007 is this finished? |
Yes, I'm eagerly waiting for merging it to continue. I prefer several small PRs to the single big one. |
Thanks for the work, much appreciated. |
Currently the test suit does not run on Windows because the test suit actively uses posix shell scripts. A solution can be converting shell scripts to d scripts. This is an initial .d version of run-unittest.sh.
run-unittest.sh performs the following tasks:
test
directory (except it self and common.sh)test
directory (if it is not disabled for a package)This PR moves task N1 from run-unittest.sh to run-unittest.d