Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing run-unittest.sh by run-unittest.d. Inception #2084

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

drug007
Copy link
Contributor

@drug007 drug007 commented Jan 21, 2021

Currently the test suit does not run on Windows because the test suit actively uses posix shell scripts. A solution can be converting shell scripts to d scripts. This is an initial .d version of run-unittest.sh.

run-unittest.sh performs the following tasks:

  1. running all scripts in test directory (except it self and common.sh)
  2. building, running and testing all D packages in test directory (if it is not disabled for a package)

This PR moves task N1 from run-unittest.sh to run-unittest.d

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @drug007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

test/run-unittest.d Outdated Show resolved Hide resolved
test/run-unittest.d Show resolved Hide resolved
test/run-unittest.d Outdated Show resolved Hide resolved
test/run-unittest.d Show resolved Hide resolved
test/run-unittest.d Outdated Show resolved Hide resolved
test/run-unittest.d Show resolved Hide resolved
test/run-unittest.d Outdated Show resolved Hide resolved
test/run-unittest.d Outdated Show resolved Hide resolved
@veelo
Copy link
Contributor

veelo commented Jan 25, 2021

I like your initiative here. There are a lot of shell scripts to convert, though :-)

@drug007
Copy link
Contributor Author

drug007 commented Jan 25, 2021

Thank you for your review! Yes, there is much work here but it can be done step-by-step.
P.S. what is funny that I use Linux most of all)

@drug007
Copy link
Contributor Author

drug007 commented Jan 25, 2021

@veelo I guess I shouldn't do forced push to keep the review?

@veelo
Copy link
Contributor

veelo commented Jan 25, 2021

@veelo I guess I shouldn't do forced push to keep the review?

I think forced push is fine. I can still click "Show resolved" to see the review and your replies. It keeps the history short when merging without having to squash commits, which is nice.

@drug007
Copy link
Contributor Author

drug007 commented Jan 25, 2021

Ok, thanks for info.

@maxhaton
Copy link
Member

maxhaton commented Feb 1, 2021

@drug007 is this finished?

@drug007
Copy link
Contributor Author

drug007 commented Feb 1, 2021

Yes, I'm eagerly waiting for merging it to continue. I prefer several small PRs to the single big one.

@maxhaton maxhaton merged commit 92cc346 into dlang:master Feb 1, 2021
@Geod24
Copy link
Member

Geod24 commented Feb 1, 2021

Thanks for the work, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants