Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor imports. #2094

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Refactor imports. #2094

merged 1 commit into from
Jan 25, 2021

Conversation

veelo
Copy link
Contributor

@veelo veelo commented Jan 24, 2021

dub.internal.vibecompat.inet.url is not directly used, but publicly imported dub.internal.vibecompat.inet.path is.

splitter is a used symbol, but it resolves to std.string.splitter (forcing use of std.regex.splitter gives a template instantiation error, so that is clearly not used). No other symbols from std.regex are used; checked manually.

No use of std.typecons symbols could be found.

std.compiler was statically imported, which was trivial to check.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @veelo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@dlang-bot dlang-bot merged commit da24acc into dlang:master Jan 25, 2021
@veelo veelo deleted the dependency-unused-imports branch January 25, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants