Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a regression with DFLAGS environment variable and cached generated unittest #2116

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fixed a regression with DFLAGS environment variable and cached generated unittest #2116

merged 1 commit into from
Mar 9, 2021

Conversation

foerdi
Copy link

@foerdi foerdi commented Mar 7, 2021

I fixed a regression that @Geod24 found: #2005 (comment)

Should I or @Geod24 open an issue and link it with this PR?

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @foerdi! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@foerdi foerdi mentioned this pull request Mar 7, 2021
Merged
Geod24
Geod24 reviewed Mar 7, 2021
View reviewed changes
source/dub/dub.d
@@ -701,10 +701,10 @@ class Dub {
mkdirRecurse(mainfile.parentPath.toNativeString());

bool regenerateMainFile = settings.force || !existsFile(mainfile);

auto escapedMainFile = mainfile.toNativeString().replace("$", "$$");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dlang.org/phobos/std_process.html#.escapeShellFileName

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately escapeShellFileName is not working, I got this Error Error: unrecognized file extension d'

Geod24
Geod24 reviewed Mar 7, 2021
View reviewed changes
test/cache-generated-test-config.sh Outdated
@@ -4,6 +4,7 @@
cd ${CURR_DIR}/cache-generated-test-config
rm -rf .dub

## defult test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## defult test
## default test

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Geod24
Copy link
Member

Geod24 commented Mar 7, 2021

Can you also add a test with a non-empty DFLAGS ?

@Geod24
Copy link
Member

Geod24 commented Mar 7, 2021

Also please target stable

@foerdi foerdi force-pushed the fixed-dflags-env-with-unittests branch 2 times, most recently from 06ed973 to 48de4b5 Compare March 9, 2021 14:17
@foerdi foerdi changed the base branch from master to stable March 9, 2021 14:21
@foerdi foerdi force-pushed the fixed-dflags-env-with-unittests branch from 48de4b5 to 7591f71 Compare March 9, 2021 14:23
@foerdi
Copy link
Author

foerdi commented Mar 9, 2021

Can you also add a test with a non-empty DFLAGS ?
Also please target stable

sure

@Geod24 Geod24 merged commit a19e02d into dlang:stable Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geod24 Geod24 Geod24 approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foerdi @dlang-bot @Geod24